What to Look for in a Code Review
Minimum price
Suggested price

What to Look for in a Code Review

Effective tips for reviewing code

About the Book

A series of tips on what to look for when doing code reviews, including aspects of testing, security, performance and more. The book is a compilation of blog posts on the same topic available on the Upsource blog

About the Author

Trisha Gee
Trisha Gee

Trisha is a Java Champion, published author, and Java Developer Advocacy team lead at JetBrains. Trisha has developed Java applications for a range of industries of all sizes, including finance, manufacturing and non-profit. She has expertise in Java high performance systems, dabbles with Open Source development, and is a leader of the Sevilla Java User Group.

Trisha’s exceptionally passionate about sharing things that help real developers. That might be: getting them up to speed on the latest version of Java; teaching them tips and tricks to save time with IntelliJ IDEA; or promoting healthy technical communities across the globe. Trish values helping all developers level up their career and skills at every step of their journey.

Read more from Trisha in the books “97 Things Every Java Developer Should Know” and “What to Look for in a Code Review”. Trisha also produces a monthly newsletter for JetBrains, Java Annotated Monthly, which is a great summary of a month in the Java world.

Table of Contents

  • JetBrains Technical Series
    • About this book
  • About the author
  • Introduction
    • What do you look for when reviewing someone else’s code?
    • What should you look for
  • Tests
    • Ask yourself these questions
    • Reviewers can write tests too
    • Summary
  • Performance
    • Performance Requirements
    • Calls outside of the service/application are expensive
    • Using resources efficiently and effectively
    • Warning signs a reviewer can easily spot
    • Correctness
    • Code-level optimisations
    • Summary
  • Data Structures
    • Lists
    • Maps
    • Sets
    • Stacks
    • Queues
    • Why select the right data structure?
    • Summary
  • SOLID Principles
    • What is SOLID?
    • Single Responsibility Principle (SRP)
    • Open-Closed Principle (OCP)
    • Liskov Substitution Principle (LSP)
    • Interface Segregation Principle (ISP)
    • Mino Dependency Inversion Principle (DIP)
    • Summary
  • Security
    • Automation is your friend
    • Sometimes “It Depends”
    • Understand your Dependencies
    • Summary
  • Upsource Quick Wins
    • Navigation
    • Inspections
    • Exception Handling Issues
    • Probable Bugs
    • Code can be simplified
    • Unused Code
    • Summary

About the Publisher

This book is published on Leanpub by JetBrains

We help developers work faster by automating common, repetitive tasks to enable them to stay focused on code design and the big picture. We provide tools to explore and familiarize with code bases faster. Our products make it easy for you to take care of quality during all stages of development and spend less time on maintenance tasks. 

Our JetBrains Technical Series of books focuses on general computer science topics as well as tooling.


The Leanpub 45-day 100% Happiness Guarantee

Within 45 days of purchase you can get a 100% refund on any Leanpub purchase, in two clicks.

See full terms

Do Well. Do Good.

Authors have earned$10,884,695writing, publishing and selling on Leanpub, earning 80% royalties while saving up to 25 million pounds of CO2 and up to 46,000 trees.

Learn more about writing on Leanpub

Free Updates. DRM Free.

If you buy a Leanpub book, you get free updates for as long as the author updates the book! Many authors use Leanpub to publish their books in-progress, while they are writing them. All readers get free updates, regardless of when they bought the book or how much they paid (including free).

Most Leanpub books are available in PDF (for computers), EPUB (for phones and tablets) and MOBI (for Kindle). The formats that a book includes are shown at the top right corner of this page.

Finally, Leanpub books don't have any DRM copy-protection nonsense, so you can easily read them on any supported device.

Learn more about Leanpub's ebook formats and where to read them

Write and Publish on Leanpub

You can use Leanpub to easily write, publish and sell in-progress and completed ebooks and online courses!

Leanpub is a powerful platform for serious authors, combining a simple, elegant writing and publishing workflow with a store focused on selling in-progress ebooks.

Leanpub is a magical typewriter for authors: just write in plain text, and to publish your ebook, just click a button. (Or, if you are producing your ebook your own way, you can even upload your own PDF, EPUB and/or MOBI files and then publish with one click!) It really is that easy.

Learn more about writing on Leanpub