What to Look for in a Code Review
This book is 100% complete
Completed on 2016-01-25
About the Book
A series of tips on what to look for when doing code reviews, including aspects of testing, security, performance and more. The book is a compilation of blog posts on the same topic available on the Upsource blog.
JetBrains Technical Series
- About this book
- About the author
- What do you look for when reviewing someone else’s code?
- What should you look for
- Ask yourself these questions
- Reviewers can write tests too
- Performance Requirements
- Calls outside of the service/application are expensive
- Using resources efficiently and effectively
- Warning signs a reviewer can easily spot
- Code-level optimisations
- Why select the right data structure?
- What is SOLID?
- Single Responsibility Principle (SRP)
- Open-Closed Principle (OCP)
- Liskov Substitution Principle (LSP)
- Interface Segregation Principle (ISP)
- Mino Dependency Inversion Principle (DIP)
- Automation is your friend
- Sometimes “It Depends”
- Understand your Dependencies
Upsource Quick Wins
- Exception Handling Issues
- Probable Bugs
- Code can be simplified
- Unused Code
This book is published on Leanpub by JetBrains
We help developers work faster by automating common, repetitive tasks to enable them to stay focused on code design and the big picture. We provide tools to explore and familiarize with code bases faster. Our products make it easy for you to take care of quality during all stages of development and spend less time on maintenance tasks.
Our JetBrains Technical Series of books focuses on general computer science topics as well as tooling.
The Leanpub 45-day 100% Happiness Guarantee
Within 45 days of purchase you can get a 100% refund on any Leanpub purchase, in two clicks.
See full terms
Free Updates. DRM Free.
If you buy a Leanpub book, you get free updates for as long as the author updates the book! Many authors use Leanpub to publish their books in-progress, while they are writing them. All readers get free updates, regardless of when they bought the book or how much they paid (including free).
Most Leanpub books are available in PDF (for computers), EPUB (for phones and tablets) and MOBI (for Kindle). The formats that a book includes are shown at the top right corner of this page.
Finally, Leanpub books don't have any DRM copy-protection nonsense, so you can easily read them on any supported device.