What to Look for in a Code Review
What to Look for in a Code Review
Effective tips for reviewing code
About the Book
A series of tips on what to look for when doing code reviews, including aspects of testing, security, performance and more. The book is a compilation of blog posts on the same topic available on the Upsource blog.
About the Author
Table of Contents
-
JetBrains Technical Series
- About this book
- About the author
-
Introduction
- What do you look for when reviewing someone else’s code?
- What should you look for
-
Tests
- Ask yourself these questions
- Reviewers can write tests too
- Summary
-
Performance
- Performance Requirements
- Calls outside of the service/application are expensive
- Using resources efficiently and effectively
- Warning signs a reviewer can easily spot
- Correctness
- Code-level optimisations
- Summary
-
Data Structures
- Lists
- Maps
- Sets
- Stacks
- Queues
- Why select the right data structure?
- Summary
-
SOLID Principles
- What is SOLID?
- Single Responsibility Principle (SRP)
- Open-Closed Principle (OCP)
- Liskov Substitution Principle (LSP)
- Interface Segregation Principle (ISP)
- Mino Dependency Inversion Principle (DIP)
- Summary
-
Security
- Automation is your friend
- Sometimes “It Depends”
- Understand your Dependencies
- Summary
-
Upsource Quick Wins
- Navigation
- Inspections
- Exception Handling Issues
- Probable Bugs
- Code can be simplified
- Unused Code
- Summary
About the Publisher
This book is published on Leanpub by JetBrains
We help developers work faster by automating common, repetitive tasks to enable them to stay focused on code design and the big picture. We provide tools to explore and familiarize with code bases faster. Our products make it easy for you to take care of quality during all stages of development and spend less time on maintenance tasks.
Our JetBrains Technical Series of books focuses on general computer science topics as well as tooling.
The Leanpub 60 Day 100% Happiness Guarantee
Within 60 days of purchase you can get a 100% refund on any Leanpub purchase, in two clicks.
Now, this is technically risky for us, since you'll have the book or course files either way. But we're so confident in our products and services, and in our authors and readers, that we're happy to offer a full money back guarantee for everything we sell.
You can only find out how good something is by trying it, and because of our 100% money back guarantee there's literally no risk to do so!
So, there's no reason not to click the Add to Cart button, is there?
See full terms...
Earn $8 on a $10 Purchase, and $16 on a $20 Purchase
We pay 80% royalties on purchases of $7.99 or more, and 80% royalties minus a 50 cent flat fee on purchases between $0.99 and $7.98. You earn $8 on a $10 sale, and $16 on a $20 sale. So, if we sell 5000 non-refunded copies of your book for $20, you'll earn $80,000.
(Yes, some authors have already earned much more than that on Leanpub.)
In fact, authors have earnedover $13 millionwriting, publishing and selling on Leanpub.
Learn more about writing on Leanpub
Free Updates. DRM Free.
If you buy a Leanpub book, you get free updates for as long as the author updates the book! Many authors use Leanpub to publish their books in-progress, while they are writing them. All readers get free updates, regardless of when they bought the book or how much they paid (including free).
Most Leanpub books are available in PDF (for computers) and EPUB (for phones, tablets and Kindle). The formats that a book includes are shown at the top right corner of this page.
Finally, Leanpub books don't have any DRM copy-protection nonsense, so you can easily read them on any supported device.
Learn more about Leanpub's ebook formats and where to read them
